Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide backward compatibility for install deps #98

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

BjoernAtBosch
Copy link
Member

@BjoernAtBosch BjoernAtBosch commented Sep 17, 2024

With this PR we could upgrade the C++ SDK to the latest version of devenv-devcontainer-setup without using the build-system which requires further work.
Changes calling velocitas exec build-system install to ./install_dpendencies.sh, which triggers

  • the build-system in repos which already support this
  • the old-style script in those repos which don't.

@BjoernAtBosch BjoernAtBosch changed the title Provide backward compatibility for setup component Provide backward compatibility for install deps Sep 17, 2024
@BjoernAtBosch
Copy link
Member Author

Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doosuu
Copy link
Member

doosuu commented Sep 18, 2024

@BjoernAtBosch whats the matter with build-system?

@BjoernAtBosch
Copy link
Member Author

@BjoernAtBosch whats the matter with build-system?

There are issues in the workflows requiring the conan profiles in the old place and some other mismatches that were not easily fixable (at least not for me)

@BjoernAtBosch BjoernAtBosch merged commit 0a8627f into main Sep 19, 2024
17 checks passed
@BjoernAtBosch BjoernAtBosch deleted the add_backward_compat branch September 19, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants