Added handling of the case where we're within a Tokio Runtime or not #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…based on a check * if we're within a Tokio Runtime use the current handle * if not, use a dedicated Tokio Runtime we have (e.g. we're within an async-std executor)
evshary
reviewed
Jun 26, 2024
There was a problem hiding this comment.
Interesting. I didn't find that the plugins in zenoh are still using async_std. Also, my assumption of using tokio might be wrong. I'm ok with the current change, but maybe there is a better way to be compatible with both tokio and aync_std. Let's figure it out later.
src/utransport.rs
Outdated
| use std::{sync::Arc, time::Duration}; | ||
| use tokio::runtime::Runtime; |
There was a problem hiding this comment.
I prefer to merge the crate path together.
Signed-off-by: ChenYing Kuo <[email protected]>
|
@PLeVasseur I know you might need the PR urgently for the uStreamer demo. I take the liberty to update the PR and merge it. I hope it doesn't offend you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added handling of the case where we're within a Tokio Runtime or not
Why
To handle the current case / issue of trying to send a Request UMessage within a Zenoh Plugin on zenoh 0.11.0-rc3, which I think still uses async-std. Therefore we need to ensure we use a dedicated Tokio Runtime in that case within up-transport-zenoh-rust.
With this change, we resolve this issue pointed out on the up-linux-streamer-plugin PR: