Add support for mapping messages to CloudEvents #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Do we really want to pull this in as a copy? Or maybe revive the download&compile functionality we originally used in build.rs for external proto files?
There was a problem hiding this comment.
I would rather keep it in our source tree. It is a tagged version (i.e. immutable) and only a single file ...
There was a problem hiding this comment.
Mh. I'll defer to your judgement on this :) Would it make sense to mention this in NOTICE.md?
There was a problem hiding this comment.
Good idea, will do.
sophokles73
force-pushed
the
add_support_for_protobuf_cloudevents
branch
from
8d38738 to
50089cf
Compare
|
@AnotherDaniel would you mind taking another look? |
Added support for mapping UMessages to/from CloudEvents using Protobuf format.
sophokles73
force-pushed
the
add_support_for_protobuf_cloudevents
branch
from
50089cf to
5e22fff
Compare
|
@AnotherDaniel I have updated the NOTICE.md file accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for mapping UMessages to/from CloudEvents using Protobuf format.
Addresses #203