Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Add shape for border node initial positioning #4453

Merged
merged 2 commits into from
Jan 31, 2025
Merged

[doc] Add shape for border node initial positioning #4453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46ca3c8
[doc] Add shape for border node initial position
lfasani Jan 31, 2025
fed9929
[releng] Bump version to 2025.1.4
sbegaudeau Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- Improve image export
- Add the current selection to the URL of the project workbench
- Improve the customization of the navigation bar
- Add support for border node initial positioning


=== Architectural decision records
Expand Down
47 changes: 47 additions & 0 deletions doc/iterations/2025.2/add_support_for_border_node_initial_positioning.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
= Add Support For Border Node Initial Positioning

== Problem

In a diagram, a `Border Node` is always created on the right of the `Node`(EAST position).

== Key Result

As a specifier, I can define, in the `View` model the side of the `Node` where the `Border Node` will be created.

As an end-user, I can see that the border node is created on the right side of the node accordingly to the view model.

== Solution

Currently, there is only the `NodeDescription` concept used for container, node and border node.
A `NodeDescription` is considered as the description of a border node if it is contained by the feature `NodeDescription.borderNodeDescriptions`

We need to define the information on which side of the parent node will the border node be created.
The information will be hold by the parent layout strategy `NodeDescription.childrenLayoutStrategy`


```
class LayoutStrategyDescription {
onWestAtCreationBorderNodes: List<NodeDescription>
onEastAtCreationBorderNodes: List<NodeDescription>
onNorthAtCreationBorderNodes: List<NodeDescription>
onSouthAtCreationBorderNodes: List<NodeDescription>
}
```

For those four features, we will make sure that

* the specifier is capable of selecting only the border nodes of the current NodeDescription
* a given border node description can only be in one of the four features

== Cutting Backs

No

== Rabbit Holes

Not identified.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this line

With this proposal, we avoid putting the information on border node itself because it would lower the reusability of this border node.

== No-Gos

No
4 changes: 2 additions & 2 deletions integration-tests/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "sirius-web-integration-tests",
"version": "2025.1.3",
"version": "2025.1.4",
"license": "EPL-2.0",
"private": true,
"devDependencies": {
Expand Down
44 changes: 22 additions & 22 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@eclipse-sirius/sirius-components-parent",
"version": "2025.1.3",
"version": "2025.1.4",
"author": "Eclipse Sirius",
"license": "EPL-2.0",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/backend/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-charts-parent</artifactId>
<version>2025.1.3</version>
<version>2025.1.4</version>

<name>sirius-components-charts-parent</name>
<description>Sirius Components Charts Parent</description>
Expand Down
8 changes: 4 additions & 4 deletions packages/charts/backend/sirius-components-charts-graphql/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
</parent>
<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-charts-graphql</artifactId>
<version>2025.1.3</version>
<version>2025.1.4</version>
<name>sirius-components-charts-graphql</name>
<description>Sirius Components Charts GraphQL</description>

Expand All @@ -47,17 +47,17 @@
<dependency>
<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-graphql-api</artifactId>
<version>2025.1.3</version>
<version>2025.1.4</version>
</dependency>
<dependency>
<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-collaborative-charts</artifactId>
<version>2025.1.3</version>
<version>2025.1.4</version>
</dependency>
<dependency>
<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-tests</artifactId>
<version>2025.1.3</version>
<version>2025.1.4</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
6 changes: 3 additions & 3 deletions packages/charts/backend/sirius-components-charts/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
</parent>
<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-charts</artifactId>
<version>2025.1.3</version>
<version>2025.1.4</version>
<name>sirius-components-charts</name>
<description>Sirius Components Charts</description>

Expand All @@ -50,7 +50,7 @@
<dependency>
<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-representations</artifactId>
<version>2025.1.3</version>
<version>2025.1.4</version>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
Expand All @@ -60,7 +60,7 @@
<dependency>
<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-tests</artifactId>
<version>2025.1.3</version>
<version>2025.1.4</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
10 changes: 5 additions & 5 deletions packages/charts/backend/sirius-components-collaborative-charts/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
</parent>
<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-collaborative-charts</artifactId>
<version>2025.1.3</version>
<version>2025.1.4</version>
<name>sirius-components-collaborative-charts</name>
<description>Sirius Components Collaborative Charts</description>

Expand Down Expand Up @@ -51,23 +51,23 @@
<dependency>
<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-charts</artifactId>
<version>2025.1.3</version>
<version>2025.1.4</version>
</dependency>
<dependency>
<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-collaborative</artifactId>
<version>2025.1.3</version>
<version>2025.1.4</version>
</dependency>
<dependency>
<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-tests</artifactId>
<version>2025.1.3</version>
<version>2025.1.4</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-spring-tests</artifactId>
<version>2025.1.3</version>
<version>2025.1.4</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/frontend/sirius-components-charts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@eclipse-sirius/sirius-components-charts",
"version": "2025.1.3",
"version": "2025.1.4",
"author": "Eclipse Sirius",
"license": "EPL-2.0",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/compatibility/backend/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<groupId>org.eclipse.sirius</groupId>
<artifactId>sirius-components-compatibility-parent</artifactId>
<version>2025.1.3</version>
<version>2025.1.4</version>

<name>sirius-components-compatibility-parent</name>
<description>Sirius Components Compatibility Parent</description>
Expand Down
Loading
Loading