Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[36] Avoid using costly Exception for package not found errors #40

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

pcdavid
Copy link
Member

@pcdavid pcdavid commented Jun 4, 2024

Bug: #36
Signed-off-by: Pierre-Charles David [email protected]

@pcdavid pcdavid added this to the 2024.7.0 milestone Jun 4, 2024
@pcdavid pcdavid linked an issue Jun 4, 2024 that may be closed by this pull request
@pcdavid
Copy link
Member Author

pcdavid commented Jun 4, 2024

I've only converted PackageNotFoundException for the moment. If we think this is the right approach, it should probably be generalized to the other JsonException subtypes.

Otherwise, if we decide we need these to be exceptions, another approach will be needed. Maybe add an optional flag to disable this reporting?

@sbegaudeau sbegaudeau merged commit d735322 into master Jun 5, 2024
3 checks passed
@sbegaudeau sbegaudeau deleted the pcd/opt/exceptions branch June 5, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PackageNotFoundException is instanciated a lot and quite costly
2 participants