Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: update gitlint documentation #145

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

AlexanderLanin
Copy link
Member

The documentation of enabled/disabled rules was a little off. And I was wondering why a body is required, until I found the commit message guidelines, so it seems to make sense to add that link.

The documentation of enabled/disabled rules was a little off. And I was wondering why a body is required, until I found the commit message guidelines, so it seems to make sense to add that link.
Copy link
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be consistent with what I can read in the git guidelines, so LGTM.

Copy link
Contributor

@pahmann pahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared the changes for enabling and disabling according to what is mentioned in line 23 of the file ("ignore=T3,T5,B1,B5,B7")

@pahmann pahmann merged commit 21849a7 into eclipse-score:main Jan 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants