-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
As described in the linked issue, this switches py_binary and py_library to aspect_rules_py. This way there is no dependency to the system python executable. Python is included anyway, since 'format.fix' requires a system python installation
- Loading branch information
1 parent
49d8db4
commit eae387b
Showing
5 changed files
with
39 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# One devcontainer? | ||
In the main repository eclipse-score/score the focus is on documentation, therefore the devcontainer | ||
is specifically tailored to that purpose. To simplify the setup, only one devcontainer is used, | ||
for both documentation and development of documentation tooling. | ||
|
||
In other eclipse-score repositories, the situation is different and either a combined devcontainer | ||
or multiple devcontainers is more appropriate. | ||
|
||
# Why is Python included? | ||
Unfortunately multiple python related bazel targets rely on the system python installation. | ||
|
||
`py_library` and `py_binary` targets are prominent examples, however they can trivially | ||
be fixed by using `aspect_rules_py` instead of `rules_python`. Bug-report: https://github.com/bazelbuild/rules_python/issues/691 | ||
|
||
|
||
Others are not as easy to work around, e.g. `format.fix`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
{ | ||
"image": "mcr.microsoft.com/devcontainers/python:1.2-3.12", | ||
"features": { | ||
"ghcr.io/devcontainers-community/features/bazel:1": {} | ||
}, | ||
"customizations": { | ||
"vscode": { | ||
"extensions": [ | ||
"ms-python.python", | ||
"usernamehw.errorlens", | ||
"hediet.vscode-drawio", | ||
"swyddfa.esbonio", | ||
"lextudio.restructuredtext" | ||
] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters