Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectPreferences: mt hardening #1715

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -75,24 +75,24 @@ public class ProjectPreferences extends EclipsePreferences {
*/
private static final Set<String> loadedNodes = ConcurrentHashMap.newKeySet();
private IFile file;
private boolean initialized = false;
private volatile boolean initialized;
/**
* Flag indicating that this node is currently reading values from disk,
* to avoid flushing during a read.
*/
private boolean isReading;
private volatile boolean isReading;
/**
* Flag indicating that this node is currently writing values to disk,
* to avoid re-reading after the write completes.
*/
private boolean isWriting;
private volatile boolean isWriting;
private IEclipsePreferences loadLevel;
private final IProject project;
private final String qualifier;

// cache
private final int segmentCount;
private Workspace workspace;
private volatile Workspace workspace;

static void deleted(IFile file) throws CoreException {
IPath path = file.getFullPath();
Expand Down
Loading