Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ARCH_X86 and WS_WPF constants and constant for ppc64le architecture in o.e.core.runtime.Platform #1576

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Deprecate ARCH_X86 and WS_WPF constants and constant for ppc64le architecture in o.e.core.runtime.Platform #1576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6446751
Add constant for ppc64le architecture in Platform class
HannesWell Oct 2, 2024
780ea05
Deprecate ARCH_X86 and WS_WPF constants in o.e.core.runtime.Platform
HannesWell Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...dles/org.eclipse.core.runtime/src/org/eclipse/core/internal/runtime/InternalPlatform.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@
*/
public final class InternalPlatform {

private static final String[] ARCH_LIST = { Platform.ARCH_AARCH64, Platform.ARCH_X86, Platform.ARCH_X86_64 };
private static final String[] ARCH_LIST = { Platform.ARCH_AARCH64, Platform.ARCH_PPC64LE, Platform.ARCH_RISCV64,
Platform.ARCH_X86_64 };

public static final StackWalker STACK_WALKER = StackWalker.getInstance(StackWalker.Option.RETAIN_CLASS_REFERENCE);

Expand Down Expand Up @@ -132,7 +133,7 @@ public final class InternalPlatform {

private static final InternalPlatform singleton = new InternalPlatform();

private static final String[] WS_LIST = { Platform.WS_COCOA, Platform.WS_GTK, Platform.WS_WIN32, Platform.WS_WPF };
private static final String[] WS_LIST = { Platform.WS_COCOA, Platform.WS_GTK, Platform.WS_WIN32 };
private IPath cachedInstanceLocation; // Cache the path of the instance location
private ServiceTracker<Location,Location> configurationLocation = null;
private BundleContext context;
Expand Down
12 changes: 12 additions & 0 deletions runtime/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/Platform.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,9 @@ public static boolean isMac() {
* </p>
*
* @since 3.0
* @deprecated not supported anymore
*/
@Deprecated
public static final String ARCH_X86 = "x86";//$NON-NLS-1$

/**
Expand Down Expand Up @@ -417,6 +419,14 @@ public static boolean isMac() {
*/
public static final String ARCH_AARCH64 = "aarch64";//$NON-NLS-1$

/**
* Constant string (value {@code ppc64le}) indicating the platform is running on
* an little-endian PowerPC 64bit based architecture.
*
* @since 3.32
*/
public static final String ARCH_PPC64LE = "ppc64le"; //$NON-NLS-1$

/**
* Constant string (value {@code riscv64} indicating the platform is running on
* an RISC-V 64bit-based architecture.
Expand Down Expand Up @@ -540,7 +550,9 @@ public static boolean isMac() {
* machine using the WPF windowing system.
*
* @since 3.3
* @deprecated not supported anymore
*/
@Deprecated
public static final String WS_WPF = "wpf";//$NON-NLS-1$

/**
Expand Down
Loading