Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Icon in Help View #1571

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

BeckerWdf
Copy link
Contributor

"container_obj" files had the wrong size.

Fixes eclipse-platform/eclipse.platform.images#94

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ua/org.eclipse.help.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 2e1f39df7c82233ec877dc052a72589b03097a9c Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 30 Sep 2024 08:11:10 +0000
Subject: [PATCH] Version bump(s) for 4.34 stream


diff --git a/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF b/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
index 6d0dc96cef..59d53f3a98 100644
--- a/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
+++ b/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %help_system_plugin_name
 Bundle-SymbolicName: org.eclipse.help.ui; singleton:=true
-Bundle-Version: 4.7.100.qualifier
+Bundle-Version: 4.7.200.qualifier
 Bundle-Activator: org.eclipse.help.ui.internal.HelpUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.46.1

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 26m 53s ⏱️ + 2m 29s
 3 981 tests ±0   3 959 ✅ ±0   22 💤 ±0  0 ❌ ±0 
12 540 runs  ±0  12 376 ✅ ±0  164 💤 ±0  0 ❌ ±0 

Results for commit 68214ea. ± Comparison against base commit 6d514be.

@BeckerWdf BeckerWdf merged commit 2f90d3c into eclipse-platform:master Sep 30, 2024
17 checks passed
@BeckerWdf BeckerWdf deleted the help_icon branch September 30, 2024 09:08
@BeckerWdf BeckerWdf self-assigned this Sep 30, 2024
@BeckerWdf BeckerWdf added this to the 4.34 M2 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect size of org.eclipse.help.ui/icons/obj16/container_obj.png
2 participants