Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate and restructure resources watson tests to JUnit 5 #903 #1554

Merged

Conversation

HeikoKlare
Copy link
Contributor

Migrates the tests in org.eclipse.core.tests.internal.watson to JUnit 5.

  • Exchange JUnit 4 test annotations
  • Replace JUnit 4 assertions with JUnit 5 or AssertJ assertions
  • Restructure the tests: replace misused inheritance with helper class, replace polymorphic with imperative behavior specification, and parameterize tests

Contributes to #903

Copy link
Contributor

github-actions bot commented Sep 15, 2024

Test Results

 1 758 files  ±  0   1 758 suites  ±0   1h 30m 22s ⏱️ - 5m 55s
 4 158 tests +177   4 136 ✅ +177   22 💤 ±0  0 ❌ ±0 
13 071 runs  +531  12 907 ✅ +531  164 💤 ±0  0 ❌ ±0 

Results for commit 233c599. ± Comparison against base commit 007ee10.

This pull request removes 4 and adds 181 tests. Note that renamed tests count towards both.
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0
AutomatedResourceTests AllWatsonTests DeltaFlatteningTest ‑ test0
AutomatedResourceTests AllWatsonTests TreeFlatteningTest ‑ test0
AutomatedResourceTests AllWatsonTests TreeFlatteningTest ‑ testExhaustive
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[10] /solution/project1, 2
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[11] /solution/project1, 3
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[12] /solution/project1, 4
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[13] /solution/project2, -1
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[14] /solution/project2, 0
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[15] /solution/project2, 1
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[16] /solution/project2, 2
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[17] /solution/project2, 3
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[18] /solution/project2, 4
AutomatedResourceTests AllWatsonTests DeltaChainFlatteningTest ‑ test0(IPath, int)[19] /solution/project2/folder1, -1
…

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare force-pushed the junit5-resources-watson branch from 8ab816f to 0d63fd6 Compare September 15, 2024 14:37
@HeikoKlare HeikoKlare marked this pull request as ready for review September 19, 2024 15:04
@akurtakov akurtakov force-pushed the junit5-resources-watson branch from 0d63fd6 to ee307c5 Compare September 30, 2024 12:40
…tform#903

Migrates the tests in org.eclipse.core.tests.internal.watson to JUnit 5.
- Exchange JUnit 4 test annotations
- Replace JUnit 4 assertions with JUnit 5 or AssertJ assertions
- Restructure the tests: replace misused inheritance with helper class,
replace polymorphic with imperative behavior specification, and
parameterize tests

Contributes to
eclipse-platform#903
@HeikoKlare HeikoKlare force-pushed the junit5-resources-watson branch from ee307c5 to 233c599 Compare September 30, 2024 19:07
@HeikoKlare HeikoKlare merged commit 1016b36 into eclipse-platform:master Oct 1, 2024
17 checks passed
@HeikoKlare HeikoKlare deleted the junit5-resources-watson branch October 1, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant