Add jsvg 1.7.0 to eclipse-sdk target #2776
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for - eclipse-platform/eclipse.platform.swt#1638 Contributes to - eclipse-platform/eclipse.platform.swt#1438
HannesWell
commented
Jan 23, 2025
Comment on lines
+96
to
+101
| <dependency> | ||
| <groupId>com.github.weisj</groupId> | ||
| <artifactId>jsvg</artifactId> | ||
| <version>1.7.0</version> | ||
| <type>jar</type> | ||
| </dependency> |
There was a problem hiding this comment.
I wonder if we should add this to a dedicated location for better separation?
On the other hand, the settings for this location are perfectly fine.
|
/request-license-review |
License review requests: After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status. Workflow run (with attached summary files): |
This is unfortunately still await manual approval from the IP-team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for
Contributes to