[Build] Remove unused creation of missing sources in Maven publication

[HannesWell]

Since eclipse-platform/eclipse.platform.releng#126 respectively eclipse-platform/eclipse.platform.releng#167 no missing source artifacts are created anymore so the associated part of the CBIaggregator.sh script can be cleaned-up.

@merks @akurtakov or @mickaelistria or do you think that this could be useful again one day?

[akurtakov]

IMO Maven publication should not generate sources and if a missing source case arise it should be handled in build scripts and not in publishing.

[merks]

Maybe this was used for ecj in the past...

I would hope we'd never need this again...

[laeubi]

IMO Maven publication should not generate sources and if a missing source case arise it should be handled in build scripts and not in publishing.

Just wanted to mention that sources are a requirement for maven-central publication, and the recommendation is to generate a fake artifact for the cases where no source can be given.

[merks]

Yes, it's a requirement, unless you are Apache and then you can dump your open source binaries without your open source source. 😱

[HannesWell]

IMO Maven publication should not generate sources and if a missing source case arise it should be handled in build scripts and not in publishing.

Just wanted to mention that sources are a requirement for maven-central publication, and the recommendation is to generate a fake artifact for the cases where no source can be given.

Yes and that's also done for javadoc-artifacts where a note is added that references the doc bundles respectively the help.
The part to be removed is different as it creates a source-artifact with real sources it downloads from the git-repo.

But it's not used nowadays and as Ed said, hopefully won't be necessary in the future. Therefore I continue with the deletion.
Thanks for your feedback.