Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product file editor: Document bundleUrlTypes support on macOS #1379

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

sratz
Copy link
Contributor

@sratz sratz commented Aug 20, 2024

Follow-up on #1326.
Contributes to eclipse-platform/eclipse.platform.ui#1901.

Copy link

github-actions bot commented Aug 20, 2024

Test Results

   285 files  ±0     285 suites  ±0   46m 50s ⏱️ - 5m 33s
 3 580 tests ±0   3 504 ✅ +2   76 💤 ±0  0 ❌ ±0 
10 932 runs  ±0  10 701 ✅ +2  231 💤 ±0  0 ❌ ±0 

Results for commit 6d75907. ± Comparison against base commit 4a9c2a1.

♻️ This comment has been updated with latest results.

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just two tiny nitpick.

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the update.

Please squash this change into one commit.

@sratz sratz force-pushed the linkhandlers-doc branch from 7d57c44 to 6d75907 Compare August 21, 2024 16:32
@HannesWell HannesWell merged commit b8ed629 into eclipse-pde:master Aug 21, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants