Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDE-Build] Use first supported version as default javac target/source #1355

Merged

Conversation

HannesWell
Copy link
Member

Generalization of #1351

With eclipse-jdt/eclipse.jdt.core#2770 we could just use JavaCore.getAllJavaSourceVersionsSupportedByCompiler().first()

Copy link

github-actions bot commented Jul 28, 2024

Test Results

   285 files  ±0     285 suites  ±0   53m 5s ⏱️ + 2m 19s
 3 580 tests ±0   3 504 ✅ ±0   76 💤 ±0  0 ❌ ±0 
10 932 runs  ±0  10 701 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit 06d2646. ± Comparison against base commit 90a3dc1.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the use-first-supported-by-default branch from 1c250b1 to a40bf32 Compare August 6, 2024 22:03
@HannesWell HannesWell force-pushed the use-first-supported-by-default branch from a40bf32 to 06d2646 Compare August 6, 2024 23:16
@HannesWell HannesWell marked this pull request as ready for review August 7, 2024 19:05
@HannesWell HannesWell merged commit f3c556e into eclipse-pde:master Aug 7, 2024
17 checks passed
@HannesWell HannesWell deleted the use-first-supported-by-default branch August 7, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant