[PDE-Build] Use File to represent file-system paths instead of String #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And don't name variables that denote local files 'urls'.
Test Results 291 files + 2 291 suites +2 54m 3s ⏱️ + 3m 42s For more details on these errors, see this check. Results for commit 50bd4ba. ± Comparison against base commit e1b5486. |
laeubi
reviewed
Jul 27, 2024
| @@ -84,7 +85,7 @@ public abstract class AbstractScriptGenerator implements IXMLConstants, IPDEBuil | |||
| private static PDEUIStateWrapper pdeUIState; | |||
|
|
|||
| /** Location of the plug-ins and fragments. */ | |||
| protected String[] sitePaths; | |||
| protected List<File> sitePaths; | |||
There was a problem hiding this comment.
Even though its already merged, why not even use Path instead of File ?
There was a problem hiding this comment.
I thought about that as well, but it would have required more changes. Since my main goal was to get rid of the File-to-URL and URL-to-File conversion I didn't want to do that as well in this change.
But since this is all internal we can change to Path at our own discretion at any time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And don't name variables that denote local files 'urls'.