Implement pde.project description interfaces using records #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 291 files ±0 291 suites ±0 54m 12s ⏱️ -8s For more details on these errors, see this check. Results for commit 5fbd13e. ± Comparison against base commit 2ea2b29. ♻️ This comment has been updated with latest results. |
ruspl-afed
reviewed
Jul 21, 2024
ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/project/BundleProjectService.java
Show resolved
Hide resolved
The implementations were already immutable and using records avoids implementing some boilerplate code. And remove duplicated java-doc in BundleProjectService identically copied from the implemented interface.
HannesWell
force-pushed
the
records-for-project-descriptions
branch
from
0281658 to
5fbd13e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementations were already immutable and using records avoids implementing some boilerplate code.
And remove duplicated java-doc in BundleProjectService identically copied from the implemented interface.
This is the internal part of #1341.