Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DPI to 72 for splash screen #259

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

jonahgraham
Copy link
Contributor

This resolves the issue that on macOS the splash screen shows up as 1/4 the size it should starting in 2025-03

Fixes #258

This resolves the issue that on macOS the splash screen
shows up as 1/4 the size it should starting in 2025-03

Fixes eclipse-packaging#258
@jonahgraham jonahgraham merged commit b35f9d0 into eclipse-packaging:master Dec 16, 2024
11 checks passed
@jonahgraham
Copy link
Contributor Author

I am not 100% sure this resolves the issue. I recreated the splash screen the same way I normally do with GIMP and these instructions

The splash screen needs to be an (approximately) 450x300 pixels .bmp file, 24-bits RGB (maybe other depth work too, but it's not tested), **without color space information** (some SWT bug). To produce it, if the initial splash screens aren't of that form (they're usually .jpg files), open the desired splash screen variation file from the `org.eclipse.epp.package.common/splash/` folder in Gimp, resize it to approximately 450x300 with _Image > Scale_, then set DPI to 72 with _Image > Print Size_, then _File > Export_ it: choose the location `org.eclipse.epp.package.common/splash.bmp` press _Save_, and in the Export options, tick _Compatibility Options > Do not write color space information_. Apply.

The before I see is:

$ file packages/org.eclipse.epp.package.common/splash.bmp
packages/org.eclipse.epp.package.common/splash.bmp: PC bitmap, Windows 98/2000 and newer format, 450 x 301 x 32, cbSize 541938, bits offset 138

$ ll  packages/org.eclipse.epp.package.common/splash.bmp
-rw-rw-r-- 1 jonah jonah 541938 Dec 15 19:08 packages/org.eclipse.epp.package.common/splash.bmp

After (with this change):

$ file packages/org.eclipse.epp.package.common/splash.bmp
packages/org.eclipse.epp.package.common/splash.bmp: PC bitmap, Windows 3.x format, 452 x 302 x 24, image size 409512, resolution 2835 x 2835 px/m, cbSize 409566, bits offset 54

$ ll  packages/org.eclipse.epp.package.common/splash.bmp
-rw-rw-r-- 1 jonah jonah 409566 Dec 15 19:09 packages/org.eclipse.epp.package.common/splash.bmp

So there are a lot of changes between the two files. Last time this happened (https://bugs.eclipse.org/bugs/show_bug.cgi?id=575679) the issue was the DPI. I can see the before the DPI is 144 and after is 72 with GIMP (screenshot of before):

image


I simply merged this change as I don't have the local facility to test the change, once it builds and is notarized I can test the result.

@jonahgraham jonahgraham deleted the newsplash branch December 16, 2024 00:12
@jonahgraham
Copy link
Contributor Author

I simply merged this change as I don't have the local facility to test the change, once it builds and is notarized I can test the result.

I tested the result on a macbook and it looks correct now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splashscreen on macOS is 1/4 normal size (starting in 2025-03)
1 participant