Ensure that client use same endpoint for a given registration #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernard31
force-pushed
the
endpoint_registration
branch
from
bdfcd4b to
7f870ef
Compare
|
@JaroslawLegierski , @cyril2maq, It could be worth to look at this too. |
This was referenced Oct 18, 2024
Closed
sbernard31
force-pushed
the
endpoint_registration
branch
from
7f870ef to
c0cc705
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discuss at #1415
So,
Registration.getLastEndpointUsed()is nowRegistration.getEndpointUri()Authorizercheck clients use same server endpoint for a given registration.Authorizeris used inSendHandlerto check for SEND request too.The main consequence is that if you persist your registration and re-run Leshan server with different endpoint this could lead to unexpected issue. Like registration can not be reused if the server endpoint doesn't exist anymore or have different Uri.
Typically, if you persist registration and you create your endpoint with a wildcard port number (letting system pick a free port for you) when you will restart the server this will probably lead to issue. But my guess is this is not a real production use cases.