Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clinet-cf add writeAttributes support #1330

Closed
wants to merge 1 commit into from

Conversation

dellzhui
Copy link

clinet-cf add writeAttributes support

@dellzhui dellzhui closed this Oct 19, 2022
@sbernard31
Copy link
Contributor

sbernard31 commented Oct 19, 2022

@dellzhui If you open another PR I will clearly decide to ban you ! Please let discuss before. 🙏
==> #1327 (comment)
==> #1328 (comment)

@dellzhui
Copy link
Author

dellzhui commented Oct 19, 2022 via email

@sbernard31
Copy link
Contributor

So sorry for that.

No problem, we finally succeed to start a discussion.

Let's try to start to work in a clearer way.

Firstly please try :

  • to avoid duplicate comments ☝️,
  • try to format it correctly, (markdown is easy to learn and github preview or edit comment feature is great...)
  • avoid images if this is now strictly needed... better to copy/paste text.
  • if you are using image ensure that your comment really contains the image ...

I thought it had been given to the robot to detect that I did not
accept the Eclipse protocol, so I repeated the submission many times.

To fix your PR you don't need to create a new one, this would be a silly process...
Just push again in same branch (using push or push --force) and this will re-trigger PR checks.
But better to make it green on you development machine first using mvn clean install javadoc:javadoc locally.

Back to the original reason for this PR,I think it is necessary to
support writeAttributes on the client side.

It seems you also comment at : #534 (comment)
So let continue to talk about that there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants