Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable keep-alive in tcp connection #131

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukasmittag
Copy link
Contributor

We've seen 40 ms spikes periodically when meassuring latency. It seems if you disable keep-alive signals in tcp this issue goes away.

!!! DRAFT !!!

Not entirely sure this is the best way to go since channels might be closing the connection. See https://grpc.io/docs/guides/performance/#general

Will do some further tests.

@lukasmittag lukasmittag marked this pull request as draft January 30, 2025 15:00
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.11%. Comparing base (95dcfcf) to head (88de4b9).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
databroker/src/grpc/server.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   59.64%   60.11%   +0.46%     
==========================================
  Files          33       33              
  Lines       15955    16191     +236     
==========================================
+ Hits         9517     9733     +216     
- Misses       6438     6458      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant