Skip to content

Commit

Permalink
Disable testExtractVariableLongName test, use jdt behavior
Browse files Browse the repository at this point in the history 
Signed-off-by: Rob Stryker <[email protected]>
  • Loading branch information
@robstryker
robstryker committed Nov 17, 2023
1 parent 53b18a4 commit 3ec3181
Showing 1 changed file with 50 additions and 50 deletions.
100 changes: 50 additions & 50 deletions ...se.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/refactoring/ExtractVariableTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -218,56 +218,56 @@ public void testExtractVariable2() throws Exception {

assertCodeActions(cu, e1, e2, e3);
}

@Test
public void testExtractVariableLongName() throws Exception {
IPackageFragment pack1 = fSourceFolder.createPackageFragment("test1", false, null);

StringBuilder buf = new StringBuilder();
buf.append("package test1;\n");
buf.append("class A{\n");
buf.append(" void m(int i){\n");
buf.append(" String x= /*]*/\"This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.\"/*[*/;\n");
buf.append(" }\n");
buf.append("}\n");

ICompilationUnit cu = pack1.createCompilationUnit("E.java", buf.toString(), false, null);

buf = new StringBuilder();
buf.append("package test1;\n");
buf.append("class A{\n");
buf.append(" void m(int i){\n");
buf.append(" String string = \"This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.\";\n");
buf.append(" String x= /*]*/string/*[*/;\n");
buf.append(" }\n");
buf.append("}\n");

Expected e1 = new Expected("Extract to local variable (replace all occurrences)", buf.toString(), JavaCodeActionKind.REFACTOR_EXTRACT_VARIABLE);

buf = new StringBuilder();
buf.append("package test1;\n");
buf.append("class A{\n");
buf.append(" void m(int i){\n");
buf.append(" String string = \"This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.\";\n");
buf.append(" String x= /*]*/string/*[*/;\n");
buf.append(" }\n");
buf.append("}\n");
Expected e2 = new Expected("Extract to local variable", buf.toString(), JavaCodeActionKind.REFACTOR_EXTRACT_VARIABLE);

buf = new StringBuilder();
buf.append("package test1;\n");
buf.append("class A{\n");
buf.append(" private static final String THIS_IS_A_LONG_NAME_NEED_BE_TRUNCATED_THIS_IS_A_LONG_NAME_NEED_BE_TRUNCATED_THIS_IS_A_LONG_NAME_NEED = /*]*/\"This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.\"/*[*/;\n");
buf.append("\n");
buf.append(" void m(int i){\n");
buf.append(" String x= THIS_IS_A_LONG_NAME_NEED_BE_TRUNCATED_THIS_IS_A_LONG_NAME_NEED_BE_TRUNCATED_THIS_IS_A_LONG_NAME_NEED;\n");
buf.append(" }\n");
buf.append("}\n");

Expected e3 = new Expected("Extract to constant", buf.toString(), JavaCodeActionKind.REFACTOR_EXTRACT_CONSTANT);

assertCodeActions(cu, e1, e2, e3);
}
// // We no longer truncate long names, and instead trust the JDT implementation
// @Test
// public void testExtractVariableLongName() throws Exception {
// IPackageFragment pack1 = fSourceFolder.createPackageFragment("test1", false, null);
//
// StringBuilder buf = new StringBuilder();
// buf.append("package test1;\n");
// buf.append("class A{\n");
// buf.append(" void m(int i){\n");
// buf.append(" String x= /*]*/\"This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.\"/*[*/;\n");
// buf.append(" }\n");
// buf.append("}\n");
//
// ICompilationUnit cu = pack1.createCompilationUnit("E.java", buf.toString(), false, null);
//
// buf = new StringBuilder();
// buf.append("package test1;\n");
// buf.append("class A{\n");
// buf.append(" void m(int i){\n");
// buf.append(" String string = \"This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.\";\n");
// buf.append(" String x= /*]*/string/*[*/;\n");
// buf.append(" }\n");
// buf.append("}\n");
//
// Expected e1 = new Expected("Extract to local variable (replace all occurrences)", buf.toString(), JavaCodeActionKind.REFACTOR_EXTRACT_VARIABLE);
//
// buf = new StringBuilder();
// buf.append("package test1;\n");
// buf.append("class A{\n");
// buf.append(" void m(int i){\n");
// buf.append(" String string = \"This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.\";\n");
// buf.append(" String x= /*]*/string/*[*/;\n");
// buf.append(" }\n");
// buf.append("}\n");
// Expected e2 = new Expected("Extract to local variable", buf.toString(), JavaCodeActionKind.REFACTOR_EXTRACT_VARIABLE);
//
// buf = new StringBuilder();
// buf.append("package test1;\n");
// buf.append("class A{\n");
// buf.append(" private static final String THIS_IS_A_LONG_NAME_NEED_BE_TRUNCATED_THIS_IS_A_LONG_NAME_NEED_BE_TRUNCATED_THIS_IS_A_LONG_NAME_NEED = /*]*/\"This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.This is a long name need be truncated.\"/*[*/;\n");
// buf.append("\n");
// buf.append(" void m(int i){\n");
// buf.append(" String x= THIS_IS_A_LONG_NAME_NEED_BE_TRUNCATED_THIS_IS_A_LONG_NAME_NEED_BE_TRUNCATED_THIS_IS_A_LONG_NAME_NEED;\n");
// buf.append(" }\n");
// buf.append("}\n");
//
// Expected e3 = new Expected("Extract to constant", buf.toString(), JavaCodeActionKind.REFACTOR_EXTRACT_CONSTANT);
//
// assertCodeActions(cu, e1, e2, e3);
// }

@Test
public void testExtractVariableFailed() throws Exception {
Expand Down

0 comments on commit 3ec3181

Please sign in to comment.