Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual threads debug view update + JdiThread new API + unit tests #535

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

SougandhS
Copy link
Contributor

@SougandhS SougandhS commented Oct 14, 2024

What it does

Enhancement for #296
Provides better view for Virtual threads in debug view
before -
image

After -
image

image

How to test

Run the test or create an ibuild with it and try (Wont be able to see in child eclipse - existing issue)

Author checklist

@SougandhS SougandhS force-pushed the VirtualThreadDebugViewNEw branch 6 times, most recently from 5fde48e to e090a5e Compare October 14, 2024 08:49
@SougandhS
Copy link
Contributor Author

Hi @jukzi
Could you please check on this ?

@jukzi
Copy link
Contributor

jukzi commented Oct 14, 2024 via email

@SougandhS
Copy link
Contributor Author

Hi @iloveeclipse
If you are available, could you pls review this PR ?

@SougandhS SougandhS force-pushed the VirtualThreadDebugViewNEw branch 4 times, most recently from 3f9860d to dbdfc68 Compare October 15, 2024 03:50
@fdummert
Copy link

As commented in #345, this PR appears to solve the debug issues we had with virtual threads (and obviously improves the presentation of virtual threads significantly).

@jukzi jukzi merged commit 956d668 into eclipse-jdt:master Oct 21, 2024
11 checks passed
@SougandhS
Copy link
Contributor Author

SougandhS commented Oct 21, 2024

Thank you @jukzi & @fdummert

@iloveeclipse
Copy link
Member

@SougandhS : please next time provide appropriate commit message that also contains a link to the original issue.
See https://github.com/eclipse-jdt/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

@SougandhS
Copy link
Contributor Author

@SougandhS : please next time provide appropriate commit message that also contains a link to the original issue. See https://github.com/eclipse-jdt/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

Yes @iloveeclipse, will provide as per the contribution guide from now on. Thank you for pointing it out

@stephan-herrmann
Copy link
Contributor

Repeating my question from #598: the test added here uses a Java project with preview enabled (originally 23, then updated to 24). But at this time virtual threads are no longer preview. Hence shouldn't the test use a Java project without --enable-preview?

@jukzi
Copy link
Contributor

jukzi commented Jan 23, 2025

sounds ok to me. @SougandhS WDYT?

@SougandhS
Copy link
Contributor Author

@stephan-herrmann Yes it wont need preview.

@SougandhS
Copy link
Contributor Author

sounds ok to me. @SougandhS WDYT?

Agreeing with you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants