-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual threads debug view update + JdiThread new API + unit tests #535
Conversation
5fde48e
to
e090a5e
Compare
Hi @jukzi |
Hi @iloveeclipse |
3f9860d
to
dbdfc68
Compare
dbdfc68
to
f9ee916
Compare
As commented in #345, this PR appears to solve the debug issues we had with virtual threads (and obviously improves the presentation of virtual threads significantly). |
@SougandhS : please next time provide appropriate commit message that also contains a link to the original issue. |
Yes @iloveeclipse, will provide as per the contribution guide from now on. Thank you for pointing it out |
Repeating my question from #598: the test added here uses a Java project with preview enabled (originally 23, then updated to 24). But at this time virtual threads are no longer preview. Hence shouldn't the test use a Java project without |
sounds ok to me. @SougandhS WDYT? |
@stephan-herrmann Yes it wont need preview. |
Agreeing with you |
What it does
Enhancement for #296
Provides better view for Virtual threads in debug view
before -
After -
How to test
Run the test or create an ibuild with it and try (Wont be able to see in child eclipse - existing issue)
Author checklist