Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve resolution and loading error messages #680

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Improve resolution and loading error messages #680

merged 3 commits into from
Nov 27, 2024

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Nov 25, 2024 •
edited
Loading

Description

  • Improves error messages when models can not be loaded (e.g. "file not found")
  • Improves error messages when resolution fails, including information about resolution strategy failures (e.g. HTTP error code when resolution from GitHub fails)
  • Stacktraces are not any more printed unless -vv (debug) or -vvv (trace) are used

Fixes #421. Fixes #353.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Yauhenikapl
Yauhenikapl approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atextor atextor merged commit a02b5a0 into eclipse-esmf:main Nov 27, 2024
4 checks passed
@atextor atextor deleted the 421-better-error-messages branch November 27, 2024 06:48
@github-actions GitHub Actions
Copy link

Release v2.9.9 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yauhenikapl Yauhenikapl Yauhenikapl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@atextor @Yauhenikapl