Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new Jena major version 5 #659

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Oct 8, 2024


Description

Updates the code base to work with Jena >=5. This removes the custom
implementation for Jena graph nodes, which does not work any more with the
updated API and instead introduces the TokenRegistry class, which keeps track
of the mapping between (RDF parser) tokens and graph nodes so. This mapping is
used for sorting subjects when pretty printing Aspect Models and reporting
location details about semantic validation errors.

Fixes #656.

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Note: Even though this is a breaking change, it only applies to APIs internal to esmf-sdk.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [-] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atextor atextor merged commit a1621f5 into eclipse-esmf:main Oct 8, 2024
4 checks passed
@atextor atextor deleted the 656-update-to-jena-5 branch October 8, 2024 08:46
Copy link

Release v2.9.6 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Update to Jena 5
2 participants