-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lower bound to org.eclipse.core.runtime in ui.discovery due to #604
Update lower bound to org.eclipse.core.runtime in ui.discovery due to #604
Conversation
cc @ptziegler |
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
Just updating the lower bound won't be enough. The PatternFilter needs to be migrated as well. This seems like an easy change, but I won't be able to do this before this evening when I'm back home. |
I will push the change now. |
I don't see a push, I push my changes. Feel free to override |
3a16668
to
4b878d5
Compare
I gave it a try, please have a look. |
...nox.p2.ui.discovery/src/org/eclipse/equinox/internal/p2/ui/discovery/util/PatternFilter.java
Show resolved
Hide resolved
Please remember that instead of |
4b878d5
to
0e8baf7
Compare
Thanks @ptziegler. PR updated. Please review. |
Thanks @ptziegler I will wait for the verification build and merge, as @iloveeclipse also set his concerns to resolved. |
cc @merks as one of his tools might be using Discovery UI |
The new quality gate error seems unrelated: https://ci.eclipse.org/equinox/job/p2/job/PR-604/4/maven-warnings/new/ I merge this now so that the aggregator build can re-run. |
new API