Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lower bound to org.eclipse.core.runtime in ui.discovery due to #604

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Jan 8, 2025

new API

@vogella
Copy link
Contributor Author

vogella commented Jan 8, 2025

cc @ptziegler

@eclipse-equinox-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.equinox.p2.ui.discovery/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From de7bf116f87f014db0929d92aeefdba753209d6d Mon Sep 17 00:00:00 2001
From: Eclipse Equinox Bot <[email protected]>
Date: Wed, 8 Jan 2025 08:04:54 +0000
Subject: [PATCH] Version bump(s) for 4.35.0 stream


diff --git a/bundles/org.eclipse.equinox.p2.ui.discovery/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.p2.ui.discovery/META-INF/MANIFEST.MF
index f2e1f16e3..0eb0e664e 100644
--- a/bundles/org.eclipse.equinox.p2.ui.discovery/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.equinox.p2.ui.discovery/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.equinox.p2.ui.discovery;singleton:=true
-Bundle-Version: 1.3.400.qualifier
+Bundle-Version: 1.3.500.qualifier
 Bundle-Vendor: %Bundle-Vendor
 Bundle-Localization: plugin
 Bundle-RequiredExecutionEnvironment: JavaSE-17
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

@ptziegler
Copy link
Contributor

Just updating the lower bound won't be enough. The PatternFilter needs to be migrated as well.

This seems like an easy change, but I won't be able to do this before this evening when I'm back home.

@iloveeclipse
Copy link
Member

I will push the change now.

@vogella
Copy link
Contributor Author

vogella commented Jan 8, 2025

I will push the change now.

I don't see a push, I push my changes. Feel free to override

@vogella vogella force-pushed the Update_lower_bound_to_org.eclipse.core.runtime_due_to_new_API branch from 3a16668 to 4b878d5 Compare January 8, 2025 08:41
@vogella
Copy link
Contributor Author

vogella commented Jan 8, 2025

This seems like an easy change, but I won't be able to do this before this evening when I'm back home.

I gave it a try, please have a look.

@ptziegler
Copy link
Contributor

Please remember that instead of matcher.match(), you now have to call matcher.matchWords().

@vogella vogella force-pushed the Update_lower_bound_to_org.eclipse.core.runtime_due_to_new_API branch from 4b878d5 to 0e8baf7 Compare January 8, 2025 09:03
@vogella
Copy link
Contributor Author

vogella commented Jan 8, 2025

Please remember that instead of matcher.match(), you now have to call matcher.matchWords().

Thanks @ptziegler. PR updated. Please review.

@vogella
Copy link
Contributor Author

vogella commented Jan 8, 2025

Thanks @ptziegler I will wait for the verification build and merge, as @iloveeclipse also set his concerns to resolved.

@vogella
Copy link
Contributor Author

vogella commented Jan 8, 2025

cc @merks as one of his tools might be using Discovery UI

Copy link

github-actions bot commented Jan 8, 2025

Test Results

  375 files  ±0    375 suites  ±0   47m 33s ⏱️ - 6m 54s
1 904 tests ±0  1 901 ✅ ±0  3 💤 ±0  0 ❌ ±0 
6 712 runs  ±0  6 703 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit 0e8baf7. ± Comparison against base commit 575bb68.

@vogella
Copy link
Contributor Author

vogella commented Jan 8, 2025

The new quality gate error seems unrelated: https://ci.eclipse.org/equinox/job/p2/job/PR-604/4/maven-warnings/new/

I merge this now so that the aggregator build can re-run.

@vogella vogella merged commit 84c9596 into eclipse-equinox:master Jan 8, 2025
11 of 12 checks passed
@vogella vogella deleted the Update_lower_bound_to_org.eclipse.core.runtime_due_to_new_API branch January 8, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants