Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use a job in the FileInfoReader #600

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Jan 7, 2025

The FileInfoReader currently creates a job just to join its execution, as the job is also marked as a system job to hide it from the users this does not seem very useful and only complicates the flow and increased the workload.

This now removes the job extension and also making the monitor field obsolete now.

The FileInfoReader currently creates a job just to join its execution,
as the job is also marked as a system job to hide it from the users this
does not seem very useful and only complicates the flow and increased
the workload.

This now removes the job extension and also making the monitor field
obsolete now.
@merks
Copy link
Contributor

merks commented Jan 7, 2025

The existing design does make debugging and understanding the flows more challenging.

Copy link

github-actions bot commented Jan 7, 2025

Test Results

  375 files  ±0    375 suites  ±0   44m 7s ⏱️ +53s
1 904 tests ±0  1 901 ✅ ±0  3 💤 ±0  0 ❌ ±0 
6 712 runs  ±0  6 703 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit b5ed068. ± Comparison against base commit 1d1d416.

@laeubi laeubi merged commit acf77b6 into eclipse-equinox:master Jan 7, 2025
12 checks passed
@jukzi
Copy link
Contributor

jukzi commented Jan 8, 2025

i wonder if the removal of join() will implicitly fix the deadlock eclipse-pde/eclipse.pde#1481

@laeubi
Copy link
Member Author

laeubi commented Jan 8, 2025

i wonder if the removal of join() will implicitly fix the deadlock eclipse-pde/eclipse.pde#1481

There was never a deadlock. The JobManager is suspended at this time, that means join() return immediately so the code is running in circles as fast as possible because the (ECF Download) Job it is waiting here is never started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants