Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for bundles/org.eclipse.equinox.security.macosx #819

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

eclipse-equinox-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible

@eclipse-equinox-bot
Copy link
Contributor Author

eclipse-equinox-bot commented Jan 29, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.equinox.security.macosx/META-INF/MANIFEST.MF
bundles/org.eclipse.equinox.security.macosx/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 1885a10625c6ccecbe7e36d6742b2e6572a8b9ed Mon Sep 17 00:00:00 2001
From: Eclipse Equinox Bot <[email protected]>
Date: Thu, 30 Jan 2025 03:15:48 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.equinox.security.macosx/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.security.macosx/META-INF/MANIFEST.MF
index 77c710747..8e01ac60a 100644
--- a/bundles/org.eclipse.equinox.security.macosx/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.equinox.security.macosx/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %fragmentName
 Bundle-SymbolicName: org.eclipse.equinox.security.macosx;singleton:=true
-Bundle-Version: 1.102.300.qualifier
+Bundle-Version: 1.102.400.qualifier
 Bundle-Vendor: %providerName
 Fragment-Host: org.eclipse.equinox.security;bundle-version="[1.0.0,2.0.0)"
 Bundle-RequiredExecutionEnvironment: JavaSE-17
diff --git a/bundles/org.eclipse.equinox.security.macosx/pom.xml b/bundles/org.eclipse.equinox.security.macosx/pom.xml
index 8e1e6156e..c014410b3 100644
--- a/bundles/org.eclipse.equinox.security.macosx/pom.xml
+++ b/bundles/org.eclipse.equinox.security.macosx/pom.xml
@@ -19,7 +19,7 @@
   </parent>
   <groupId>org.eclipse.platform</groupId>
   <artifactId>org.eclipse.equinox.security.macosx</artifactId>
-  <version>1.102.300-SNAPSHOT</version>
+  <version>1.102.400-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
 
   <properties>
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

github-actions bot commented Jan 29, 2025

Test Results

  669 files  +  223    669 suites  +223   1h 17m 3s ⏱️ + 26m 53s
2 223 tests ±    0  2 176 ✅ +    1   47 💤  -  1  0 ❌ ±0 
6 813 runs  +2 271  6 670 ✅ +2 224  143 💤 +47  0 ❌ ±0 

Results for commit 2213d7c. ± Comparison against base commit 7def4c5.

♻️ This comment has been updated with latest results.

@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.security.macosx branch from 46e3289 to cd62e2e Compare January 30, 2025 03:12
@laeubi laeubi merged commit 5cc678b into master Jan 30, 2025
28 of 29 checks passed
@laeubi laeubi deleted the clean-code/bundles/org.eclipse.equinox.security.macosx branch January 30, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants