Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for bundles/org.eclipse.equinox.preferences #816

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Clean Code for bundles/org.eclipse.equinox.preferences #816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...nox.preferences/src/org/eclipse/core/internal/preferences/OSGiPreferencesServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ public class OSGiPreferencesServiceImpl implements PreferencesService {
private static final class OSGiLocalRootPreferences implements Preferences {

// The "local" root of this preference tree (not the real Eclipse root)
private Preferences root;
private final Preferences root;

// the node this node is wrappering
private Preferences wrapped;
private final Preferences wrapped;

private OSGiLocalRootPreferences(Preferences root) {
this(root, root);
Expand Down Expand Up @@ -252,7 +252,7 @@ public void sync() throws BackingStoreException {

} // end static inner class OSGiLocalRootPreferences

private IEclipsePreferences bundlePreferences;
private final IEclipsePreferences bundlePreferences;

OSGiPreferencesServiceImpl(IEclipsePreferences bundlePreferences) {
this.bundlePreferences = bundlePreferences;
Expand Down
8 changes: 4 additions & 4 deletions ...pse.equinox.preferences/src/org/eclipse/core/runtime/preferences/IEclipsePreferences.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public final class NodeChangeEvent extends EventObject {
*/
private static final long serialVersionUID = 1L;

private Preferences child;
private final Preferences child;

/**
* Constructor for a new node change event object.
Expand Down Expand Up @@ -127,9 +127,9 @@ public final class PreferenceChangeEvent extends EventObject {
*/
private static final long serialVersionUID = 1L;

private String key;
private Object newValue;
private Object oldValue;
private final String key;
private final Object newValue;
private final Object oldValue;

/**
* Constructor for a new preference change event. The node and the key must not
Expand Down
Loading