Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Win32] Opt-in for long path capability in Eclipse application manifest #657

Closed

Conversation

HannesWell
Copy link
Member

@HannesWell
Copy link
Member Author

@sravanlakkimsetti or @niraj-modi can you tell if that change makes sense?

The goal is to fix the failures of PDE-tests in I-builds (see eclipse-pde/eclipse.pde#1333) since the paths on the test machines got longer and now exceed the default limit.
The test machine has already opt-ed in for long paths (https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4832) but the application has to opt-in too. I hope that this is the thing to do.

Copy link

Test Results

  660 files  ±0    660 suites  ±0   1h 11m 39s ⏱️ +40s
2 195 tests ±0  2 148 ✅ ±0   47 💤 ±0  0 ❌ ±0 
6 729 runs  ±0  6 586 ✅ ±0  143 💤 ±0  0 ❌ ±0 

Results for commit 5936e94. ± Comparison against base commit 95971b5.

@vogella
Copy link
Contributor

vogella commented Jul 22, 2024

Great, ran into this multiple times with clients and Oomph IIRC.

Once this is in, please add to N&N with the information which registry key to set

@HannesWell
Copy link
Member Author

After some more research I found JDK Bug 8315405 which states that there is no perfect way to circumvent the MAX_PATH length limit for the working directory of launched processes on Windows.
This is probably also the reason why the JDK itself does not declar long-path compatibility in its executable manifest:
https://github.com/openjdk/jdk/blob/d63d6e23d123e82cef1372aed31b5846fb6d23fd/src/java.base/windows/native/launcher/java.manifest#L39-L43

But with eclipse-platform/eclipse.platform#1477 I have created a work-around based on shortened MS-DOS naming convention. At least this should permit longer paths than currently possible. It is most effective if a path consists of only few long segments.

This can be closed.

@HannesWell HannesWell closed this Jul 22, 2024
@HannesWell HannesWell deleted the no-path-limit-windows branch July 22, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants