Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for jackson 2.12 #7

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

ghillairet
Copy link
Contributor

Fix for #6

@juergen-albert
Copy link

I gave it a try and it seems to do the job. @ghillairet thanks heaps for fixing this!

@PhilippeBrossel
Copy link

I tried it out, and your fix solves the issue for me.
@ghillairet : Many thanks for this great tool !
Btw, I had to add a /META-INF/MANIFEST.MF with an adequate Export-Package to be able to access the packages org.emfjson.jackson.* from my plugin-projects
(Was just to circumvent the warning This plug-in does not have an OSGI bundle manifest.)
Is there a better way to do that or can you give me a hint of what I'm doing wrong ?

@debovema
Copy link

debovema commented Aug 5, 2021

Can someone merge this ?

Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the fix, @ghillairet . Btw, we are in the process of setting up the build infrastructure for this so it might not be immediately consumable right now.

@martin-fleck-at martin-fleck-at merged commit 1a5a7af into eclipse-emfcloud:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants