Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assertThrows #142

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Use assertThrows #142

merged 1 commit into from
Nov 21, 2024

Conversation

marschall
Copy link
Contributor

Use assertThrows instead of try-fail-catch where possible.

@marschall
Use assertThrows
789f84c 
Use assertThrows instead of try-fail-catch where possible.
@marschall
Copy link
Contributor Author

Looks like this was missed in #115

jbescos
jbescos approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@jbescos jbescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbescos jbescos merged commit 34177db into eclipse-ee4j:master Nov 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbescos jbescos jbescos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marschall @jbescos