Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor MojarraRuntimePopulator conform DRY #5539

Merged
merged 8 commits into from
Dec 28, 2024

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Dec 21, 2024

Wanted to add new system event listeners for 5.0 but saw a super bloated MojarraRuntimePopulator -- refactored with a little help of Grok

MojarraRuntimePopulator -- refactored from 2261 loc to 146 loc with a
little help of Grok
@BalusC BalusC requested review from arjantijms and mnriem December 21, 2024 15:39
@BalusC
Copy link
Contributor Author

BalusC commented Dec 28, 2024

TCK is green and need to move forward with 5.0, so merging.

@BalusC BalusC merged commit 539daba into master Dec 28, 2024
3 checks passed
@BalusC BalusC deleted the refactor_MojarraRuntimePopulator branch December 28, 2024 12:58
Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing a test?

@BalusC
Copy link
Contributor Author

BalusC commented Jan 3, 2025

The entire TCK is the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants