Issue #2217 "Enhances line terminator for chunk-size in Chunked Transfer Coding #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjan Tijms <[email protected]>
Next version is 4.0.1
Signed-off-by: Arjan Tijms <[email protected]>
Update versions in poms and adjust pom where needed for that
This way subclasses making use of this ctor can set parameters without getting NPE. Signed-off-by: Arjan Tijms <[email protected]>
Create empty SSL parameters in protected ctor
Signed-off-by: Arjan Tijms <[email protected]>
Fix generation of javadoc
Fixes eclipse-ee4j#2192 - Grizzly 2.4.4/4.0.0 missing Content-Type in response
Update main branch with stray commits from other branches
merge 4.0.1 into main
Signed-off-by: Arjan Tijms <[email protected]>
Signed-off-by: Arjan Tijms <[email protected]>
JDK 17
4.1 for Servlet 6.1 / EE 11
…hunked Transfer Coding" (eclipse-ee4j#2217) + When the org.glassfish.grizzly.http.STRICT_CHUNKED_TRANSFER_CODING_LINE_TERMINATOR_RFC_9112 option is enabled, only CRLF is allowed as the chunk-size line terminator in Chunked Transfer Coding. + Added testcase depending on whether option is present or not
|
Unclear target branch - should it be |
|
@pzygielo When I look at the source tree, it looks like main is correct. I'm wondering if I should clean up the PR based on main again, or if I should merge it to master first and then move it to main. |
|
Moved to #2220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parsingState.checkpoint2(extra parsing state field) was not used in chunked transfer coding.This was added to verify the CR before LF.
If it were not provided as an option, the code logic could be cleaner, but I provided it as an option within the range that does not affect stability and existing operation as much as possible.