Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected method call in SSLEngineConfigurator.configure #2210

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

kaido207
Copy link
Contributor

@kaido207 kaido207 commented Jun 4, 2024

@kaido207
Copy link
Contributor Author

kaido207 commented Jun 6, 2024

@arjantijms
Could you review this patch?

And, the CI job "Build Grizzly on JDK 17" is failing.
Error Message:

Error:  Detected Maven Version: 3.8.8 is not in the allowed range [3.8.9,).

It seems the reason is that the following changes have modified the required minimal Maven version to 3.8.9, but the version within the CI environment is 3.8.8.
ce35c04#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8

@carryel
Copy link
Contributor

carryel commented Jan 3, 2025

@kaido207 github actions fixed. #2221
Could you please re-run based on the latest main?

@carryel carryel self-requested a review January 3, 2025 04:30
@kaido207
Copy link
Contributor Author

kaido207 commented Jan 6, 2025

@carryel
Thank you for your fixed.
I done re-run.

@carryel carryel merged commit 9b28fb9 into eclipse-ee4j:main Jan 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants