Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Woodstox 7.0.0 #25003

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Integrate Woodstox 7.0.0 #25003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e0e8bf
Integrate Woodstox 7.0.0
arjantijms Jun 24, 2024
6c83f93
Try Metro 4.0.4
arjantijms Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appserver/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@

<!-- Used for Jakarta SOAP (XML Web Services) -->
<xmlsec.version>4.0.2</xmlsec.version>
<woodstox.version>6.6.2</woodstox.version>
<woodstox.version>7.0.0</woodstox.version>
<stax2-api.version>4.2.2</stax2-api.version>

<!-- Jakarta CDI -->
Expand Down
2 changes: 1 addition & 1 deletion nucleus/parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
<!-- Jakarta SOAP (with Attachments)
<jakarta.xml.soap-api.version>3.0.0-RC2</jakarta.xml.soap-api.version>
-->
<webservices.version>4.0.3</webservices.version>
<webservices.version>4.0.4</webservices.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, looking at other deps, it will probably fail again unless EL-API gets updated to 6.0.0 and Servlet-API to 6.1.0; XML-WS related APIs should be updated to their latest versions too, but should not cause any troubles if not given their updates are fully backward compatible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't update those in GF 7 to those versions, since they are Jakarta EE 11 dependencies.

GlassFish 8 is for Jakarta EE 11, GlassFish 7 is for Jakarta EE 10.

What we really need is a Metro / WebServices with Jakarta EE 10 dependencies (so no Expression Language 6 and no Servlet 6.1), but with WoodStox 7.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukasj Can you do a Metro / Webservices 4.0.4 with only WoodStox updated to 7 (or, even better, just widen the protection in OSGi to include 6 and 7). Then do a Metro / Webservices 4.1.x for Jakarta EE 11?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Try 4.0.4 again. It should be ok for use in EE 10 as well as 11 now. Given EE 10 requires SE 11, I see no point in keeping woodstox 6.x allowed.

anyway XML-WS related APIs should be updated to their latest versions note remains valid; <jakarta.xml.soap-api.version>3.0.0-RC2</jakarta.xml.soap-api.version> is definitely wrong even for EE 10 final

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3.0.0-RC2 only seems to occur in a comment:

   <!-- Jakarta SOAP (with Attachments)
       <jakarta.xml.soap-api.version>3.0.0-RC2</jakarta.xml.soap-api.version>
        -->

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in server.log of the clustered instance. I have no idea why the test passed locally. Some cached dependency on CI from staging repo ?

Caused by: java.lang.ClassNotFoundException: jakarta.servlet.ServletContainerInitializer not found by org.glassfish.metro.webservices-osgi [299]
	at org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1591)
	at org.apache.felix.framework.BundleWiringImpl.access$300(BundleWiringImpl.java:79)
	at org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:1976)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
	... 96 more
]]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org.glassfish.* is being cached on the CI indeed. If Metro uses that and Lukas re-staged 4.0.4, that might be the issue.

There is a job to clear the cache.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukasj can we release metro / webservices 4.0.4 to Maven Central?


<!-- Jakarta Inject -->
<jakarta.inject-api.version>2.0.1.MR</jakarta.inject-api.version>
Expand Down