Exclude grizzly artifacts bundled into grizzly-core already #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `grizzly-core` bundles both `grizzly-framework` and `grizzly-portunif` AND declares them as dependencies in default scope (compile). This helps to avoid on `shoal-gms-impl` usage: ``` [ERROR] Duplicate classes found: [ERROR] [ERROR] Found in: [ERROR] org.glassfish.grizzly:grizzly-framework:jar:4.0.1:compile [ERROR] org.glassfish.grizzly:grizzly-core:jar:4.0.1:compile [ERROR] Duplicate classes: [ERROR] org/glassfish/grizzly/memory/AbstractMemoryManager$TrimAware.class [ERROR] org/glassfish/grizzly/ssl/SSLBaseFilter$4.class ... [ERROR] [ERROR] Found in: [ERROR] org.glassfish.grizzly:grizzly-core:jar:4.0.1:compile [ERROR] org.glassfish.grizzly:grizzly-portunif:jar:4.0.1:compile [ERROR] Duplicate classes: [ERROR] org/glassfish/grizzly/portunif/finders/HttpProtocolFinder.class [ERROR] org/glassfish/grizzly/portunif/PUFilter$SuspendedContextCopyListener.class ... ```
|
Hmmm, we should give some love to Grizzly too ... this smells badly. Especially because usual convention is that "framework" artifacts usually contain their repackaged dependencies which then are NOT in their compile dependencies. |
This could help: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
grizzly-corebundles bothgrizzly-frameworkandgrizzly-portunifAND declares them as dependencies in default scope (compile).This helps to avoid on
shoal-gms-implusage:IMO the ideal would be to have it corrected in grizzly itself.