docs: update CONTRIBUTING.md with ECA instead of Google CLA #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested changes
Feb 6, 2025
Comment on lines
-6
to
16
| ## Contributor License Agreement | ||
| ## Eclipse Contributor Agreement | ||
|
|
||
| Contributions to this project must be accompanied by a Contributor License | ||
| Agreement. You (or your employer) retain the copyright to your contribution; | ||
| Contributions to this project must be accompanied by an Eclipse Contributor Agreement (ECA). | ||
| You (or your employer) retain the copyright to your contribution; | ||
| this simply gives us permission to use and redistribute your contributions as | ||
| part of the project. Head over to <https://cla.developers.google.com/> to see | ||
| your current agreements on file or to sign a new one. | ||
| part of the project. Head over to <https://www.eclipse.org/projects/handbook/#specifications-contributors> to understand | ||
| how to sign the ECA. | ||
|
|
||
| You generally only need to submit a CLA once, so if you've already submitted one | ||
| You generally only need to submit the ECA once, so if you've already submitted one | ||
| (even if it was for a different project), you probably don't need to do it | ||
| again. |
There was a problem hiding this comment.
I appreciate this hacking of the google license agreement :) , but I think we can just stick to have a link to the Contribution Guidelines on the website and remove everything else
There was a problem hiding this comment.
Haha, that's what I get for trying to be fancy! :)
Thx for the feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR changes the CONTRIBUTING.md. The file instructed cutributors to sign Google's CLA instead of the correct ECA (Eclipse Contributor Agreement)
Why it does that
I believe the file was created by some automated scaffolding script, which refers to Google's CLA.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
@ndr-brt
Linked Issue(s)
Closes #49
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.