-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: build.gradle.kts imports fixed #227
Conversation
"libs.edc.control.plane.api" added "libs.edc.control.plane.api" duplication eliminated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'
I tried to label this issue as a bug, but I guess I don't have the permissions. |
This pull request is stale because it has been open for 7 days with no activity. |
Hi, thanks for the contribution, please follow the contribution guide, a PR should be preceded by an issue or an additional discussion beforehand: furthermore, the title of the PR is not valid, please verify the failing check. |
Thanks for the comments. I will create a issue or discussions in a future contributions. On the other hand, I changed the title using the following regex:
|
I created a method to check if the title will pass the regex:
|
What this PR changes/adds
"transfer/transfer-04-event-consumer/consumer-with-listener/build.gradle.kts" modified:
"libs.edc.control.plane.api" added
"libs.edc.control.plane.api" duplication eliminated
Why it does that
We were running the guide examples and we wanted to reuse the connector.jar of "transfer-04-event-consumer" to all cases, but when we run the "Simple Provider push Http transfer flow" example we noticed that a 404 error appeared.
Comparing gradles we noticed that exists a duplicated and missing import in the 04 version. We copied the same imports from version 00 to 04 and all worked.
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.