Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build.gradle.kts imports fixed #227

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

alzcurda
Copy link
Contributor

What this PR changes/adds

"transfer/transfer-04-event-consumer/consumer-with-listener/build.gradle.kts" modified:

"libs.edc.control.plane.api" added
"libs.edc.control.plane.api" duplication eliminated

Why it does that

We were running the guide examples and we wanted to reuse the connector.jar of "transfer-04-event-consumer" to all cases, but when we run the "Simple Provider push Http transfer flow" example we noticed that a 404 error appeared.

Comparing gradles we noticed that exists a duplicated and missing import in the 04 version. We copied the same imports from version 00 to 04 and all worked.

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

 "libs.edc.control.plane.api" added
 "libs.edc.control.plane.api" duplication eliminated
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'

@alzcurda
Copy link
Contributor Author

I tried to label this issue as a bug, but I guess I don't have the permissions.

@alzcurda alzcurda changed the title fix: "transfer/transfer-04-event-consumer/consumer-with-listener/build.gradle.kts" imports fixed fix: transfer/transfer-04-event-consumer/consumer-with-listener/build.gradle.kts imports fixed Mar 19, 2024
Copy link

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Mar 27, 2024
@ndr-brt ndr-brt added bug Something isn't working and removed stale Open for x days with no activity labels Mar 27, 2024
@ndr-brt
Copy link
Member

ndr-brt commented Mar 29, 2024

Hi, thanks for the contribution, please follow the contribution guide, a PR should be preceded by an issue or an additional discussion beforehand:
https://eclipse-edc.github.io/docs/#/documentation/CONTRIBUTING

furthermore, the title of the PR is not valid, please verify the failing check.

@alzcurda alzcurda changed the title fix: transfer/transfer-04-event-consumer/consumer-with-listener/build.gradle.kts imports fixed fix transfer-04-event-consumer consumer-with-listener build.gradle.kts imports fixed Mar 31, 2024
@alzcurda
Copy link
Contributor Author

Thanks for the comments. I will create a issue or discussions in a future contributions.

On the other hand, I changed the title using the following regex:

^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test)(\(\w+((,|\/|\\)?\s?\w+)+\))?!?: [\S ]{1,80}[^\.]$

@alzcurda alzcurda changed the title fix transfer-04-event-consumer consumer-with-listener build.gradle.kts imports fixed fix: build.gradle.kts imports fixed Apr 4, 2024
@alzcurda
Copy link
Contributor Author

alzcurda commented Apr 4, 2024

I created a method to check if the title will pass the regex:

import re

def validar_cadena(cadena):
    regex = r'^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test)(\(\w+((,|\/|\\)?\s?\w+)+\))?!?: [\S ]{1,80}[^\.]$'
    if re.match(regex, cadena):
        return True
    else:
        return False

cadena = input("Ingrese la cadena a validar: ")
if validar_cadena(cadena):
    print("La cadena es válida para la expresión regular.")
else:
    print("La cadena no es válida para la expresión regular.")

@ndr-brt ndr-brt merged commit 64575ec into eclipse-edc:main Apr 5, 2024
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants