refactor: e2e pull transfer tests #4733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmarino
requested changes
Jan 21, 2025
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
...2e-transfer-test/runner/src/test/java/org/eclipse/edc/test/e2e/TransferPullEndToEndTest.java
Outdated
Show resolved
Hide resolved
AndrYurk
force-pushed
the
refactoring-e2e-transfer-test
branch
from
3079e66 to
3d85043
Compare
jimmarino
reviewed
Jan 25, 2025
There was a problem hiding this comment.
I find the code more complex and difficult to reason about than the original due to the added layers of indirection. For example:
createResourcesOnProvider(assetId, PolicyFixtures.contractExpiresIn("10s"), httpSourceDataAddress());
var startedTransferContext = startTransferProcess(assetId);
var edrMessageContext = assertDataIsAccessible(startedTransferContext.consumerTransferProcessId);
assertDataIsNotAccessible(startedTransferContext.consumerTransferProcessId, edrMessageContext);
Compare the above to the original where the checks are well-documented and intuitive.
In tests, it's OK to repeat code if it makes what is being verified easier to follow. There are obviously cases where test fixtures should be used, but generalized methods need to explicitly communicate what verification they are performing.
My suggestion is to try an alternative approach or keep the existing test case structure.
| @@ -340,6 +265,55 @@ private HttpResponse cacheEdr(HttpRequest request, Map<String, TransferProcessSt | |||
| } | |||
| } | |||
|
|
|||
| private StartedTransferContext startTransferProcess(String assetId) { | |||
There was a problem hiding this comment.
This is an unnecessary indirection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Refactor End-to-End (e2e) PULL Transfer Tests.
Why it does that
Please see issue description.
Linked Issue(s)
Closes #4727
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.