chore: deprecate provider_id field in ContractRequest

[Pluci]

What this PR changes/adds

Deprecated provider_id field in ContractRequest

Why it does that

Clean up.

Linked Issue(s)

Closes #3929

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

[github-actions]

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

[ndr-brt]

hey @Pluci I think the objective here would be not just to deprecate a constant, but also update the api spec (currently that field is mandatory on the management api) and also remove the providerId field from the ContractRequest POJO and ensure that the information is extracted from the enclosed policy

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 65.42%. Comparing base (7f20ba5) to head (ef69102).
Report is 143 commits behind head on main.

Files	Patch %	Lines
...ator/jsonobject/validators/LogDeprecatedValue.java	0.00%	12 Missing ⚠️
...ontract/spi/types/negotiation/ContractRequest.java	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3948      +/-   ##
==========================================
- Coverage   71.74%   65.42%   -6.32%     
==========================================
  Files         919      976      +57     
  Lines       18457    19706    +1249     
  Branches     1037     1107      +70     
==========================================
- Hits        13242    12893     -349     
- Misses       4756     6377    +1621     
+ Partials      459      436      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Pluci]

hey @Pluci I think the objective here would be not just to deprecate a constant, but also update the api spec (currently that field is mandatory on the management api) and also remove the providerId field from the ContractRequest POJO and ensure that the information is extracted from the enclosed policy

hi @ndr-brt, thank you for the suggestions. I'm going to fix those as well.

[ndr-brt]

already mergeable, I will wait for the validator refactor and the dependencies file fix

[ndr-brt]

2 nits, please fix checkstyle issues and dependecies file and we'll be ready to go 👍

[Pluci]

The failing unit test is working fine in the local environment, so I have no idea why it's failing on the CI/CD pipeline.

[ndr-brt]

The failing unit test is working fine in the local environment, so I have no idea why it's failing on the CI/CD pipeline.

sincerely I got no clue, also on my machine it works correctly, anyway, please try to change line 80 of that test this way:
.satisfies(transformed -> assertThat(transformed.getProtocol()).isNotBlank()));

[ndr-brt]

LGTM