Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make Services return Lists and not Streams #3685

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Dec 4, 2023

What this PR changes/adds

Make services return collected Lists instead of Streams.

Why it does that

transactional context scope

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #3682

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Dec 4, 2023
@ndr-brt ndr-brt requested review from wolf4ood and jimmarino December 4, 2023 09:33
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0266575) 71.73% compared to head (734ffd7) 71.73%.
Report is 3 commits behind head on main.

Files Patch % Lines
...ontractagreement/ContractAgreementServiceImpl.java 71.42% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3685   +/-   ##
=======================================
  Coverage   71.73%   71.73%           
=======================================
  Files         917      919    +2     
  Lines       18426    18465   +39     
  Branches     1041     1034    -7     
=======================================
+ Hits        13217    13246   +29     
- Misses       4750     4760   +10     
  Partials      459      459           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 070229e into eclipse-edc:main Dec 4, 2023
19 of 21 checks passed
@ndr-brt ndr-brt deleted the 3682-make-services-return-lists branch December 4, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: make Services return collected Iterables and not Streams
3 participants