Skip to content

Commit

Permalink
docs: replace cryptographicSuites with cryptography (#111)
Browse files Browse the repository at this point in the history
* docs: replace cryptographicSuites with cryptography

* use correct suite identifiers

* Update artifacts/src/main/resources/issuance/example/issuer-metadata.json

Co-authored-by: Arno Weiß <[email protected]>

* Update artifacts/src/main/resources/issuance/example/credential-offer-message.json

Co-authored-by: Arno Weiß <[email protected]>

* Update specifications/dsp.profile.md

Co-authored-by: Arno Weiß <[email protected]>

---------

Co-authored-by: Arno Weiß <[email protected]>
  • Loading branch information
paullatzelsperger and arnoweiss authored Nov 25, 2024
1 parent ae898ad commit 91e2f7b
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 17 deletions.
4 changes: 2 additions & 2 deletions artifacts/src/main/resources/context/dcp.jsonld
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@
"@type": "xsd:string",
"@container": "@set"
},
"cryptographicSuites": {
"@id": "dcp:cryptographicSuites",
"cryptography": {
"@id": "dcp:cryptography",
"@type": "xsd:string",
"@container": "@set"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"type": "string"
}
},
"cryptographicSuites": {
"cryptography": {
"type": "array",
"items": {
"type": "string"
Expand Down Expand Up @@ -65,7 +65,7 @@
"credentialType",
"offerReason",
"bindingMethods",
"cryptographicSuites",
"cryptography",
"issuancePolicy"
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"bindingMethods": [
"did:web"
],
"cryptographicSuites": [
"JsonWebKey2020"
"cryptography": [
"JsonWebSignature202", "eddsa-rdfc-2022", "eddsa-jcs-2022", "..."
],
"issuancePolicy": {
"permission": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"bindingMethods": [
"did:web"
],
"cryptographicSuites": [
"JsonWebKey2020"
"cryptography": [
"JsonWebSignature2020", "eddsa-rdfc-2022", "eddsa-jcs-2022", "..."
],
"issuancePolicy": {
"permission": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"bindingMethods": [
"did:web"
],
"cryptographicSuites": [
"JsonWebKey2020"
"cryptography": [
"JsonWebSignature2020", "eddsa-rdfc-2022", "eddsa-jcs-2022", "..."
],
"issuancePolicy": {
"permission": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ public class CredentialObjectSchemaTest extends AbstractSchemaTest {
"bindingMethods": [
"did:web"
],
"cryptographicSuites": [
"JsonWebKey2020"
"cryptography": [
"JsonWebSignature2020"
],
"issuancePolicy": {
"permission": [
Expand Down Expand Up @@ -66,8 +66,8 @@ public class CredentialObjectSchemaTest extends AbstractSchemaTest {
"bindingMethods": [
"did:web"
],
"cryptographicSuites": [
"JsonWebKey2020"
"cryptography": [
"JsonWebSignature2020"
],
"issuancePolicy": {
"permission": [
Expand Down Expand Up @@ -95,7 +95,7 @@ void verifySchema() {
.containsExactly(error("credentialType", REQUIRED),
error("offerReason", REQUIRED),
error("bindingMethods", REQUIRED),
error("cryptographicSuites", REQUIRED),
error("cryptography", REQUIRED),
error("issuancePolicy", REQUIRED));

assertThat(schema.validate(INVALID_CREDENTIAL_REQUEST_MESSAGE_NO_TYPE_AND_CONTEXT, JSON))
Expand Down
2 changes: 1 addition & 1 deletion specifications/credential.issuance.protocol.md
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ The following is a non-normative example of a credential offer request:
| | - `@type`: A string specifying the `CredentialObject` type |
| | - `credentialType`: An array of strings defining the type of credential being offered |
| **Optional** | - `bindingMethods`: An array of strings defining the key material that an issued credential is bound to |
| | - `cryptographicSuites`: An array of strings defining the algorithm used for credential signing |
| | - `cryptography`: An array of strings defining the algorithm used for credential signing |
| | - `issuancePolicy`: An ODRL Policy [[odrl-model]]. Note that the ODRL Policy MUST not contain `target` attributes |
| | - `offerReason`: A reason for the offer as a string. Valid values may include `reissue` and `proof-key-revocation` |

Expand Down
2 changes: 1 addition & 1 deletion specifications/dsp.profile.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ catalog. The `CredentialsSupported` object contains the following properties:
- `types`: REQUIRED. An array of verifiable credential type strings the credential corresponds to
- `bindingMethod`: REQUIRED. String that identifies how the credential is bound to the identifier of the
credential holder.
- `cryptographicSuites` REQUIRED. An array of strings that identify the cryptographic suites supported for verifying
- `cryptography` REQUIRED. An array of strings that identify the cryptographic standards supported for verifying
proofs. Values should either use those defined
by [IANA JOSE](https://www.iana.org/assignments/jose/jose.xhtml#web-signature-encryption-algorithms) for JWT-based VCs
or the [Linked Data Cryptographic Suite Registry](https://w3c-ccg.github.io/ld-cryptosuite-registry/) for LD-based
Expand Down

0 comments on commit 91e2f7b

Please sign in to comment.