Do not validate Bitbucket Server by Api request #757
+3
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
tolusha
approved these changes
Jan 24, 2025
|
/retest |
|
Verified on Eclipse Che with The functionality works properly. |
artaleks9
approved these changes
Jan 28, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, tolusha, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the 'isApiRequestRelevant()' function from the Bitbucket Server flow. The function tests the given url if it belongs to Bitbucket Server by doing a user request. Bitbucket Server returns an empty string for unauthorized user without any specific messages. This is a problem as other unsupported git services might work in the same way, so we can not relay on that because if some unsupported git service also returns an empty string on an unsupported api request, the function will incorrectly mark the given url as Bitbucket Server.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23303
How to test this PR?
see eclipse-che/che#23303
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.