Add Azure DevOps Server support #754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
tolusha
reviewed
Jan 23, 2025
| } | ||
|
|
||
| protected AzureDevOpsUrl withDevfileFilenames(List<String> devfileFilenames) { | ||
| this.devfileFilenames.addAll(devfileFilenames); | ||
| return this; | ||
| } | ||
|
|
||
| public AzureDevOpsUrl withServerUrl(String serverUrl) { | ||
| this.serverUrl = serverUrl; |
There was a problem hiding this comment.
When use set serverUrl, then hostname is null, which is used later in getRepositoryLocation
| @@ -172,8 +172,19 @@ public Optional<Boolean> isValid(PersonalAccessToken personalAccessToken) { | |||
| public Optional<Pair<Boolean, String>> isValid(PersonalAccessTokenParams params) | |||
| throws ScmCommunicationException { | |||
| if (!isValidScmServerUrl(params.getScmProviderUrl())) { | |||
| LOG.debug("not a valid url {} for current fetcher ", params.getScmProviderUrl()); | |||
| return Optional.empty(); | |||
| if (OAUTH_PROVIDER_NAME.equals(params.getScmProviderName())) { | |||
There was a problem hiding this comment.
Can we refactor this fuction?
For instance, move if (OAUTH_PROVIDER_NAME.equals(params.getScmProviderName())) { before if (!isValidScmServerUrl(params.getScmProviderUrl())) {
| azureDevOpsApiClient.getUserWithPAT( | ||
| personalAccessToken.getToken(), personalAccessToken.getScmOrganization()); | ||
| return new GitUserData(user.getDisplayName(), user.getEmailAddress()); | ||
| if (personalAccessToken.getScmProviderUrl().equals("https://dev.azure.com")) { |
There was a problem hiding this comment.
We have AzureDevOps class for contants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add Azure DevOps Server support to use with PAT ONLY, as the azure Devops Api does not support oauth2, see: eclipse-che/che#23306 (comment)
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23306
How to test this PR?
quay.io/eclipse/che-serve:pr-754Organizationinput to enter theCollectionname.See: workspace starts with the devfile resolve.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.