Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass status code to Exception on Unauthorised to GitHub Error #618

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Nov 27, 2023

What does this PR do?

Pass status code to Exception on Unauthorised to GitHub Error in order to be able to recognise GitHub Server url if oAuth is not configured and no PAT is present.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-5355

How to test this PR?

  1. Start che from the PR image: quay.io/eclipse/che-server:pr-618
  2. Start a workspace from a public GitHub server repository.

See: the workspace starts successfully.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@vinokurig
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the lgtm label Nov 29, 2023
@vinokurig
Copy link
Contributor Author

/retest

@vinokurig
Copy link
Contributor Author

/retest

@artaleks9
Copy link
Contributor

/retest

@artaleks9
Copy link
Contributor

Verified on Eclipse Che with quay.io/eclipse/che-server:pr-618, the functionality works as expected.

Copy link

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit 06e14c8 into main Jan 10, 2024
27 checks passed
@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: server_3.11/3: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.11/67 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: server_3.x/307: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5881 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.11/68: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.11/68 triggered; /job/DS_CI/job/dsc_3.11 triggered;

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.11/31: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.11/68 triggered

@devstudio-release
Copy link

Build 3.12 :: sync-to-downstream_3.x/5883: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5749 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.12 :: operator-bundle_3.x/2526: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5883 triggered

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.11/236: SUCCESS

Detected new images: rebuild operator-bundle
* server; /DS_CI/operator-bundle_3.11/31 triggered

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2382: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: dsc_3.11/29: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2383: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1723: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: update-digests_3.x/5503: SUCCESS

Detected new images: rebuild operator-bundle
* server; /DS_CI/operator-bundle_3.x/2526 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.11/29: SUCCESS

3.11.0-CI

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1723: SUCCESS

3.12.0-CI

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2382: SUCCESS

3.11
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.11-173
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-645822-533291-s390x
  + quay.io/devspaces/iib:3.11-v4.14-s390x
  + quay.io/devspaces/iib:latest-v4.14-s390x
  + quay.io/devspaces/iib:3.11-v4.13-646095-533286-s390x
  + quay.io/devspaces/iib:3.11-v4.13-s390x
  + quay.io/devspaces/iib:latest-v4.13-s390x
  + quay.io/devspaces/iib:3.11-v4.12-646083-533281-s390x
  + quay.io/devspaces/iib:3.11-v4.12-s390x
  + quay.io/devspaces/iib:latest-v4.12-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-646102-533291-x86_64
  + quay.io/devspaces/iib:3.11-v4.14-x86_64
  + quay.io/devspaces/iib:latest-v4.14-x86_64
  + quay.io/devspaces/iib:3.11-v4.13-646095-533286-x86_64
  + quay.io/devspaces/iib:3.11-v4.13-x86_64
  + quay.io/devspaces/iib:latest-v4.13-x86_64
  + quay.io/devspaces/iib:3.11-v4.12-646083-533281-x86_64
  + quay.io/devspaces/iib:3.11-v4.12-x86_64
  + quay.io/devspaces/iib:latest-v4.12-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-646102-533291-ppc64le
  + quay.io/devspaces/iib:3.11-v4.14-ppc64le
  + quay.io/devspaces/iib:latest-v4.14-ppc64le
  + quay.io/devspaces/iib:3.11-v4.13-646095-533286-ppc64le
  + quay.io/devspaces/iib:3.11-v4.13-ppc64le
  + quay.io/devspaces/iib:latest-v4.13-ppc64le
  + quay.io/devspaces/iib:3.11-v4.12-646083-533281-ppc64le
  + quay.io/devspaces/iib:3.11-v4.12-ppc64le
  + quay.io/devspaces/iib:latest-v4.12-ppc64le

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2383: SUCCESS

3.12
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.12-85
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.15-645864-x86_64
  + quay.io/devspaces/iib:3.12-v4.15-x86_64
  + quay.io/devspaces/iib:next-v4.15-x86_64
  + quay.io/devspaces/iib:3.12-v4.14-646104-533291-x86_64
  + quay.io/devspaces/iib:3.12-v4.14-x86_64
  + quay.io/devspaces/iib:next-v4.14-x86_64
  + quay.io/devspaces/iib:3.12-v4.13-646096-533286-x86_64
  + quay.io/devspaces/iib:3.12-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.12-v4.12-646087-533281-x86_64
  + quay.io/devspaces/iib:3.12-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.15-645864-s390x
  + quay.io/devspaces/iib:3.12-v4.15-s390x
  + quay.io/devspaces/iib:next-v4.15-s390x
  + quay.io/devspaces/iib:3.12-v4.14-646104-533291-s390x
  + quay.io/devspaces/iib:3.12-v4.14-s390x
  + quay.io/devspaces/iib:next-v4.14-s390x
  + quay.io/devspaces/iib:3.12-v4.13-646096-533286-s390x
  + quay.io/devspaces/iib:3.12-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.12-v4.12-646087-533281-s390x
  + quay.io/devspaces/iib:3.12-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.12-86
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.15-646106-ppc64le
  + quay.io/devspaces/iib:3.12-v4.15-ppc64le
  + quay.io/devspaces/iib:next-v4.15-ppc64le
  + quay.io/devspaces/iib:3.12-v4.14-646104-533291-ppc64le
  + quay.io/devspaces/iib:3.12-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.12-v4.13-646120-533286-ppc64le
  + quay.io/devspaces/iib:3.12-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.12-v4.12-646113-533281-ppc64le
  + quay.io/devspaces/iib:3.12-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants