use specific error for github authorization error

[jcockbain]

Signed-off-by: James Cockbain [email protected]

What type of PR is this ?

• Bug fix
• Enhancement

What does this PR do ?

Uses a specific error key (invalid_git_credentials) for whenever the Github API returns a 401 unauthorized error, when creating a project.

Example:

cwctl --json project create 
	-u https://github.ibm.com/James-Cockbain/git-basics 
	-p ~/documents/workspace/jam 
	--personalAccessToken no-token

{"error":"invalid_git_credentials","error_description":"unexpected status code: 401 Unauthorized"}
exit status 1

Modifies main tests to check for this error code in its existing bad password and access token tests.

Which issue(s) does this PR fix ?

eclipse-archived/codewind#3100

Does this PR require a documentation change ?

No

Any special notes for your reviewer ?

Modified tests require GHE credentials to be added in https://github.com/eclipse/codewind-installer/blob/master/pkg/test/globals.go.

[rwalle61]

LGTM, I guess this test https://github.com/eclipse/codewind-installer/blob/master/pkg/project/create_test.go#L101 doesn't fail because your change is to the err op code not error.Desc. If so, it miight be good to add an assertion against the err op code

[jcockbain]

@rwalle61 - that's correct. I can add that assertion 👍

[rwalle61]

LGTM except for this last thing

[rwalle61]

fyi I recently realised that the 2nd arg of assert.Equal should be the expected value, not the actual value. I.e. this (and the others) should be:

Suggested change

	assert.Equal(t, err.Op, errOpInvalidCredentials)
	assert.Equal(t, errOpInvalidCredentials, err.Op)

which is a bit confusing given that assert.Contains(t, string(out), "invalid_git_credentials") is the correct way round

[jcockbain]

oops, yeah you are right

[rwalle61]

thanks for the change, yea I only just recently noticed it #489

[rwalle61]

LGTM

[codecov]

Codecov Report

Merging #493 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   19.83%   19.86%   +0.03%     
==========================================
  Files          80       80              
  Lines        7014     7017       +3     
==========================================
+ Hits         1391     1394       +3     
  Misses       5453     5453              
  Partials      170      170              

Impacted Files	Coverage Δ
pkg/project/project_utils.go	0.00% <ø> (ø)
pkg/project/create.go	50.48% <100.00%> (+0.73%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a6baf...8146499. Read the comment docs.

[tobespc]

LGTM