Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.sh #3

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Update install.sh #3

merged 2 commits into from
Dec 3, 2024

Conversation

omfj
Copy link
Member

@omfj omfj commented Nov 24, 2024

Funker på min datamaskin.

Men ja, dette funker på MacOS nå. Bruker tar og curl som dep. Fint om du kunne sjekke at dette funker for deg og @jesperkha. Installerer ikke lengre /usr/local/bin, men $HOME/.local/bin. Tror det er mer "korrekt" å installere "personlige" binaries der.

@omfj omfj requested a review from jesperkha November 24, 2024 18:38
@jesperkha
Copy link
Collaborator

Scriptet funka men mangler cenv-install filen som også er med i release mappa

~/.local/bin er også ikke i PATH ved default, men det er vel easy fix om man ikke har lagt det til i shell config enda

@omfj
Copy link
Member Author

omfj commented Nov 24, 2024

Hvorfor skal vi ha cenv-install? Hva gjør den?

Sikker på at ~/.local/bin ikke er i PATH by default? Mener det burde være det.

@omfj
Copy link
Member Author

omfj commented Nov 24, 2024

Du har rett. Faktisk ikke default, men da skylder jeg på dårlig dotfiles. Føler det burde være ganske standard ting å da det i PATH.

@omfj
Copy link
Member Author

omfj commented Nov 24, 2024

Kan jeg flytte cenv-install greia til en kommand to cenv, f.eks cenv upgrade?

@omfj
Copy link
Member Author

omfj commented Nov 24, 2024

Se de to siste commits. La til cenv upgrade, som bare er cenv-install, og en sjekk på om cenv er på siste versjon.

@omfj omfj force-pushed the omfj/update-install-sh branch 3 times, most recently from 54506e4 to 0be7420 Compare November 27, 2024 13:14
@omfj omfj force-pushed the omfj/update-install-sh branch from 0be7420 to 31ca9ff Compare November 27, 2024 13:17
@omfj
Copy link
Member Author

omfj commented Dec 3, 2024

Er den good to go? @jesperkha

@omfj omfj force-pushed the omfj/update-install-sh branch from b827c86 to 93fde1a Compare December 3, 2024 20:34
@omfj
Copy link
Member Author

omfj commented Dec 3, 2024

Approved via DMs

@omfj omfj merged commit ae4749b into main Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants