Adopt to schema #210
Merged
Adopt to schema #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2024
linuxrider
reviewed
Jan 17, 2024
| source: | ||
| manufacturer: MaTecK GmbH | ||
| shape: | ||
| type: wire | ||
| - name: REF |
There was a problem hiding this comment.
Should we add a index to all electrodes to be ready for bipontentiostatic measurements?
Suggested change
| - name: REF | |
| - name: RE1 |
Comment on lines
28
to
31
| ph: | ||
| value: 0.1 | ||
| calculation: CurTiPot | ||
| comment: estimated |
There was a problem hiding this comment.
This is no done by the author.
Suggested change
| ph: | |
| value: 0.1 | |
| calculation: CurTiPot | |
| comment: estimated | |
| ph: | |
| value: 1.041 | |
| temperature: | |
| value: 25 | |
| unit: °C | |
| comment: estimated with CurTiPot on extraction from publication |
| temperature: | ||
| value: 20 | ||
| unit: C | ||
| comment: room temperature |
There was a problem hiding this comment.
Comment is a property of temperature. So it should stay below temperature.
Comment on lines
28
to
31
| ph: | ||
| value: 0.1 | ||
| calculation: CurTiPot | ||
| comment: estimated |
There was a problem hiding this comment.
Suggested change
| ph: | |
| value: 0.1 | |
| calculation: CurTiPot | |
| comment: estimated | |
| ph: | |
| value: 1.041 | |
| temperature: | |
| value: 25 | |
| unit: °C | |
| comment: estimated with CurTiPot on extraction from publication |
Comment on lines
28
to
31
| ph: | ||
| value: 0.1 | ||
| calculation: CurTiPot | ||
| comment: estimated |
There was a problem hiding this comment.
Suggested change
| ph: | |
| value: 0.1 | |
| calculation: CurTiPot | |
| comment: estimated | |
| ph: | |
| value: 1.041 | |
| temperature: | |
| value: 25 | |
| unit: °C | |
| comment: estimated with CurTiPot on extraction from publication |
Comment on lines
30
to
33
| ph: | ||
| value: -0.5 | ||
| calculation: CurTiPot | ||
| comment: estimated |
There was a problem hiding this comment.
Suggested change
| ph: | |
| value: -0.5 | |
| calculation: CurTiPot | |
| comment: estimated | |
| ph: | |
| value: -0.468 | |
| temperature: | |
| value: 25 | |
| unit: °C | |
| comment: estimated with CurTiPot on extraction from publication |
Comment on lines
30
to
33
| ph: | ||
| value: -1.1 | ||
| calculation: CurTiPot | ||
| comment: estimated |
There was a problem hiding this comment.
Suggested change
| ph: | |
| value: -1.1 | |
| calculation: CurTiPot | |
| comment: estimated | |
| ph: | |
| value: -1.078 | |
| temperature: | |
| value: 25 | |
| unit: °C | |
| comment: estimated with CurTiPot on extraction from publication |
Comment on lines
30
to
33
| ph: | ||
| value: -1.5 | ||
| calculation: CurTiPot | ||
| comment: estimated |
There was a problem hiding this comment.
Suggested change
| ph: | |
| value: -1.5 | |
| calculation: CurTiPot | |
| comment: estimated | |
| ph: | |
| value: -1.468 | |
| temperature: | |
| value: 25 | |
| unit: °C | |
| comment: estimated with CurTiPot on extraction from publication |
| temperature: | ||
| value: 20 | ||
| unit: C | ||
| comment: room temperature | ||
| comment: room temperature |
There was a problem hiding this comment.
Suggested change
| comment: room temperature | |
| comment: room temperature |
| temperature: | ||
| value: 20 | ||
| unit: C | ||
| comment: room temperature | ||
| comment: room temperature |
There was a problem hiding this comment.
Suggested change
| comment: room temperature | |
| comment: room temperature |
linuxrider
approved these changes
Jan 17, 2024
|
@linuxrider I see your point in these changes. At the moment they are not compatible with the schema.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt the YAML files to version 0.1.0 of the echemdb MDS