-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlay plot for comparing cyclic voltammetry #178
base: main
Are you sure you want to change the base?
Conversation
When using promises in a different way it works, i.e. the delay is gone. |
When I test this locally, I see the graph but upon selecting data it is not updated. :( |
@DunklesArchipel I forgot to mention that one needs to set an environment variable. Ok, |
Works now. I just wonder if the table in its current form is so useful. It would probably be good to have a list with identifiers to select from. And lets see how this works when the number of entries grows even more. |
Of course, the selection mechanism/table can be improved. It was not the focus for now since it should just somehow work at first. |
async function updatePlot(names) { | ||
Promise.all( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async function updatePlot(names) { | |
Promise.all( | |
function updatePlot(names) { | |
return Promise.all( |
The idea is to have a plotly plot and the data is pulled from csv on the server on demand on selection.
On the bottom of the CV page there is now a compare link, which leads to a overview page.
On this the desired CVs can be selected for overlaying them.
In the current state there is a mysterious delay with the selection. The previous selection (i.e. selection on click in the past) is displayed. Probably related to promises.Addresses #177.